Skip to content

🌱 Avoid duplicate boilerplate.#1921

Open
guettli wants to merge 7 commits intov1.1.xfrom
tg/avoid-duplicate-boilerplate
Open

🌱 Avoid duplicate boilerplate.#1921
guettli wants to merge 7 commits intov1.1.xfrom
tg/avoid-duplicate-boilerplate

Conversation

@guettli
Copy link
Copy Markdown
Collaborator

@guettli guettli commented Apr 2, 2026

Summary

Tighten the boilerplate check so files with duplicate Kubernetes license headers are rejected instead of silently passing.

Changes

  • ignore .cache while walking the repository for boilerplate checks
  • reject files that contain the Kubernetes copyright header more than once
  • add the missing boilerplate header to hack/lint-links.sh
  • remove duplicate boilerplate blocks from hack/check-capi-version.sh and test/helpers/mod.go
  • add a focused unit test for duplicate-header detection
  • keep the shell test fixture failing for the intended reason so the ensure path stays covered

Testing

  • python -m unittest boilerplate_test in hack/boilerplate
  • make verify-boilerplate

@github-actions github-actions Bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/hack Changes made in the hack directory area/test Changes made in the test directory labels Apr 2, 2026
@guettli guettli requested a review from Dhairya-Arora01 April 2, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hack Changes made in the hack directory area/test Changes made in the test directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files. waiting-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant